Skip to content

chore: 新增进度条动效和一个新进度条类 - #589

Merged
Whale107 merged 1 commit into
linuxdeepin:dev/animationfrom
Whale107:github-master
Aug 2, 2024
Merged

chore: 新增进度条动效和一个新进度条类#589
Whale107 merged 1 commit into
linuxdeepin:dev/animationfrom
Whale107:github-master

Conversation

@Whale107

@Whale107 Whale107 commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

新增进度条动效和一个新进度条类

Log:

@deepin-ci-robot

deepin-ci-robot commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 18, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
eb523c3 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
@github-actions

github-actions Bot commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@deepin-ci-robot deepin-ci-robot mentioned this pull request Jul 18, 2024
Merged
@deepin-bot

deepin-bot Bot commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/widgets/dindeterminateprogressbar.h 16 DIndeterminateProgressbar::DIndeterminateProgressbar
include/widgets/dindeterminateprogressbar.h 12 DIndeterminateProgressbar
src/widgets/private/dindeterminateprogressbar_p.h 19 QWidget* DIndeterminateProgressbarPrivate::m_sliderWidget
src/widgets/private/dindeterminateprogressbar_p.h 20 QTimer* DIndeterminateProgressbarPrivate::m_timer
src/widgets/private/dindeterminateprogressbar_p.h 21 bool DIndeterminateProgressbarPrivate::m_leftToRight
src/widgets/private/dindeterminateprogressbar_p.h 22 QWidget* DIndeterminateProgressbarPrivate::m_spotWidget
src/widgets/private/dindeterminateprogressbar_p.h 23 QPropertyAnimation* DIndeterminateProgressbarPrivate::m_animation
src/widgets/private/dindeterminateprogressbar_p.h 17 DIndeterminateProgressbarPrivate::DIndeterminateProgressbarPrivate
src/widgets/private/dindeterminateprogressbar_p.h 14 DIndeterminateProgressbarPrivate

@Whale107

Whale107 commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

deepin-bot Bot added a commit to linuxdeepin/cla that referenced this pull request Jul 23, 2024
@deepin-bot
@Whale107 has signed the CLA from Pull Request linuxdeepin/dtkwidget#589
f3cfa1c
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
a0d9b8d 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
4c33e70 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
8c43d1b 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
kegechen
kegechen reviewed Jul 31, 2024
View reviewed changes
Comment thread src/widgets/dindeterminateprogressbar.cpp Outdated
@kegechen
kegechen requested a review from zccrs July 31, 2024 09:07
zccrs
zccrs requested changes Jul 31, 2024
View reviewed changes
Comment thread include/widgets/dindeterminateprogressbar.h Outdated
Comment thread src/widgets/dtitlebar.cpp
Comment thread src/widgets/dprogressbar.cpp Outdated
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
bf35487 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
d132854 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
zccrs
zccrs requested changes Aug 1, 2024
View reviewed changes
Comment thread include/widgets/dindeterminateprogressbar.h
Comment thread src/widgets/dindeterminateprogressbar.cpp
Comment thread include/widgets/dindeterminateprogressbar.h
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
a7a7d7e 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
zccrs
zccrs requested changes Aug 1, 2024
View reviewed changes
Comment thread src/widgets/dindeterminateprogressbar.cpp
Comment thread include/widgets/dindeterminateprogressbar.h Outdated
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
eb28185 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
kegechen
kegechen reviewed Aug 2, 2024
View reviewed changes

@kegechen kegechen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在example中的progressbar加一个展示

kegechen
kegechen suggested changes Aug 2, 2024
View reviewed changes

@kegechen kegechen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无关提交去掉

kegechen
kegechen reviewed Aug 2, 2024
View reviewed changes
Comment thread src/widgets/dindeterminateprogressbar.cpp Outdated
void DIndeterminateProgressbar::setSliderSize(int size)
{
D_D(DIndeterminateProgressbar);
if (d->m_sliderWidget->width() == size)

@kegechen kegechen Aug 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能超过自己的宽度吧

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 2, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
a1b0858 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
@Whale107
chore: 新增进度条动效和一个新进度条类
8d60917 
新增进度条动效和一个新进度条类

Log:
@deepin-ci-robot

deepin-ci-robot commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • 在DIndeterminateProgressbarPrivate构造函数中，m_sliderWidget和m_spotWidget的初始化没有设置父窗口，可能会导致窗口显示异常。
  • m_timer和m_animation的定时器超时信号与动画完成信号之间可能存在冲突，可能会导致定时器无限循环。
  • paintEvent方法中，使用setClipping(true)和setClipping(false)可能会影响性能，建议使用更高效的方式来处理绘制区域。
  • paintEvent方法中，颜色值的硬编码可能不适用于所有主题，建议使用主题颜色来动态设置颜色。

是否建议立即修改:
是

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 2, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
1af0045 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
kegechen
kegechen reviewed Aug 2, 2024
View reviewed changes

@kegechen kegechen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Whale107
Whale107 merged commit b8497a4 into linuxdeepin:dev/animation Aug 2, 2024
Whale107 added a commit to Whale107/dtkwidget that referenced this pull request Sep 23, 2024
@Whale107
chore: 新增进度条动效和一个新进度条类 (linuxdeepin#589)
1c6bd50 
新增进度条动效和一个新进度条类

Log:
deepin-bot Bot pushed a commit that referenced this pull request Sep 23, 2024
@Whale107 @deepin-bot
chore: 新增进度条动效和一个新进度条类 (#589)
8ec72ae 
新增进度条动效和一个新进度条类

Log:
FeiWang1119 pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 25, 2024
@deepin-ci-robot @FeiWang1119
sync: from linuxdeepin/dtkwidget
97c146a 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zccrs zccrs zccrs requested changes
+1 more reviewer
@kegechen kegechen kegechen requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Whale107 @deepin-ci-robot @zccrs @kegechen