Skip to content

chore: 使用dci icon重绘toolbutton, 增加动画 - #594

Merged
Whale107 merged 1 commit into
linuxdeepin:dev/animationfrom
Whale107:toolbutton
Aug 22, 2024
Merged

chore: 使用dci icon重绘toolbutton, 增加动画#594
Whale107 merged 1 commit into
linuxdeepin:dev/animationfrom
Whale107:toolbutton

Conversation

@Whale107

@Whale107 Whale107 commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

使用dci icon重绘toolbutton, 增加动画

Log:

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#594
@deepin-bot

deepin-bot Bot commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟡 some documents missing!

File Line Symbol
src/widgets/private/dtoolbutton_p.h 18 DDciIcon Dtk::Widget::DToolButtonPrivate::m_dciIcon
src/widgets/private/dtoolbutton_p.h 19 DDciIconPlayer Dtk::Widget::DToolButtonPrivate::m_dciPlayer
src/widgets/private/dtoolbutton_p.h 16 Dtk::Widget::DToolButtonPrivate::DToolButtonPrivate
src/widgets/private/dtoolbutton_p.h 13 Dtk::Widget::DToolButtonPrivate

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#594
使用dci icon重绘toolbutton, 增加动画

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#594
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • DToolButtonPrivate构造函数中没有初始化m_dciPlayer,可能导致未定义行为。
  • setDciIcon函数中连接了DDciIconPlayer::updated信号,但没有处理信号的实际功能。
  • setDciIcon函数中直接修改了m_dciPlayer的属性,但没有考虑线程安全问题。
  • event函数中直接连接了DGuiApplicationHelper::themeTypeChanged信号,但没有处理信号的实际功能。
  • paintEvent函数中使用connect连接了多个信号槽,但没有考虑到性能问题。
  • paintEvent函数中直接设置了QPainter::RenderHint,但没有考虑到兼容性问题。
  • paintEvent函数中使用了QDebugQKeyEvent,但没有考虑到生产环境中的日志和事件处理。
  • paintEvent函数中使用了QMargins的构造函数,但没有考虑到跨平台兼容性问题。
  • paintEvent函数中使用了QRect的构造函数,但没有考虑到跨平台兼容性问题。
  • paintEvent函数中使用了QPenQBrush的构造函数,但没有考虑到跨平台兼容性问题。
  • paintEvent函数中使用了QStyleOptionButton的构造函数,但没有考虑到跨平台兼容性问题。
  • paintEvent函数中使用了QStylePainter的构造函数,但没有考虑到跨平台兼容性问题。

是否建议立即修改:

@Whale107
Whale107 merged commit 49cd53a into linuxdeepin:dev/animation Aug 22, 2024
Whale107 added a commit to Whale107/dtkwidget that referenced this pull request Sep 23, 2024
使用dci icon重绘toolbutton, 增加动画

Log:
deepin-bot Bot pushed a commit that referenced this pull request Sep 23, 2024
使用dci icon重绘toolbutton, 增加动画

Log:
FeiWang1119 pushed a commit to FeiWang1119/dtkwidget that referenced this pull request Sep 26, 2024
BLumia pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants