Skip to content

fix: build error on Windows#757

Open
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2
Open

fix: build error on Windows#757
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2

Conversation

@kt286

@kt286 kt286 commented Jul 16, 2026

Copy link
Copy Markdown

fix build error on Windows

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor
  • 检测到敏感词export变动
详情
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR. 😃

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-bot

deepin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.7.46
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #758

- Guard X11/Xcb/Linux-only dependencies with LINUX platform checks
  in CMakeLists
- Add Qt Svg as required dependency
- Export all symbols on Windows (non-MSVC) via linker flags
- Provide stub implementations for DKeyboardMonitor and
  StartupNotificationMonitor on non-Linux platforms
- Guard CUPS-specific code with #ifdef Q_OS_LINUX in print dialog
  and preview widget
- Use QPainter-based SVG rendering fallback on non-Linux
- Fix abs() implicit conversion warning in DImageViewer
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from da4aab4 to 6ea79dd Compare July 17, 2026 05:42
@github-actions

Copy link
Copy Markdown
Contributor
  • 检测到敏感词export变动
详情
    {
    "export": {
        "dtkwidget.cmake": {
            "b": [
                "  set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
            ]
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants