Skip to content

fix: adjust progressbar color - #237

Merged
Whale107 merged 1 commit into
linuxdeepin:dev/animationfrom
Whale107:progressbar
Aug 15, 2024
Merged

fix: adjust progressbar color#237
Whale107 merged 1 commit into
linuxdeepin:dev/animationfrom
Whale107:progressbar

Conversation

@Whale107

@Whale107 Whale107 commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

adjust progressbar color

Log:

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#237
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#237
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#237
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#237
adjust progressbar color

Log:
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#237
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • ChameleonStyle::drawControl函数中,borderColor的计算逻辑可能存在错误,原代码中的计算方式是针对亮色模式,而修改后的代码使用了DGuiApplicationHelper::adjustColor来调整颜色,但参数和计算方式可能不正确。
  • spotWidth的值从200修改为100,需要确认这是否是预期的更改,因为这会影响到spot的绘制尺寸。
  • clipPath的创建逻辑在修改后使用了rect.marginsRemoved(QMargins(1, 1, 1, 1))来移除边框,这可能是为了修正绘制错误,但需要确保这是预期的行为。
  • progressAnimation的绘制逻辑在修改后移除了marginsRemoved调用,这可能会影响动画的显示效果,需要确认这是否是预期的更改。

是否建议立即修改:

  • 需要验证borderColor的计算逻辑是否正确,并确保其值符合预期的亮色或暗色模式。
  • 确认spotWidth的修改是否符合设计要求,并确保不会对用户界面产生负面影响。
  • 验证clipPath的修改是否正确处理了边框,并确保不会对动画绘制产生负面影响。
  • 验证progressAnimation的修改是否正确处理了动画显示,并确保不会对用户界面产生负面影响。

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, Whale107

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Whale107
Whale107 merged commit 159cd6b into linuxdeepin:dev/animation Aug 15, 2024
Whale107 added a commit to Whale107/qt5integration that referenced this pull request Sep 23, 2024
Whale107 added a commit that referenced this pull request Sep 23, 2024
* feat: add animation for menu's selected backgroud

Add a ChameleonAnimation class for the geometry translate animation.

* chore: 更新滚动条样式,适配动画 (#233)

更新滚动条样式,适配动画

Log:

* chore: add round and remove shadow for menu item

add round and remove shadow for menu item

Log:

* chore: 更改checkbox和radio实现方式为dci图标,增加动效 (#236)

更改checkbox和radio实现方式为dci图标,增加动效

Log:

* fix: adjust progressbar color (#237)

adjust progressbar color

Log:

* fix: 修复在选中框之外hover 和点击也有动画的问题 (#238)

checkbox和radio有框选区和文字区,应该只对框选区事件做处理

Log:

---------

Co-authored-by: JiDe Zhang <zhangjide@deepin.org>
Co-authored-by: wangfei <wangfei@deepin.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants