Skip to content

chore: avoid build error - #233

Merged
kegechen merged 1 commit into
linuxdeepin:masterfrom
kegechen:master
Feb 22, 2024
Merged

chore: avoid build error #233
kegechen merged 1 commit into
linuxdeepin:masterfrom
kegechen:master

Conversation

@kegechen

Copy link
Copy Markdown
Contributor

If the object does not implement QDebug operator<<(QDebug , const Object *) it cannot be printed with QDebug

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Feb 20, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#233
@kegechen
kegechen requested review from ComixHe and zccrs February 20, 2024 05:20
Comment thread src/vtablehook.h Outdated

if (!rvf.oldFun) {
qCWarning(vtableHook) << "Reset the function failed, object: " << obj;
qCWarning(vtableHook) << "Reset the function failed, object: " << typeid(obj).name();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以这样:

qCWarning(vtableHook) << "Reset the function failed, object type:"
                      << QMetaType::fromType<decltype(obj)>().name()
                      << "object address:" << static_cast<void *>(obj);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

打印指针地址没啥意义,QMetaType::fromType编译会报错。

VtableHook::callOriginalFun(qApp->d_func(), &QGuiApplicationPrivate::isWindowBlocked, ...);

error: no member named 'qt_metatype_id' in 'QMetaTypeId<QGuiApplicationPrivate *>'
    static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeid(obj).name(); 也不行。。

VtableHook::callOriginalFun(drag, &QXcbDrag::startDrag);
Cannot load library /xx/xx/libdxcb.so: (/xx/xx/libdxcb.so: undefined symbol: _ZTI8QXcbDrag)
QLibraryPrivate::loadPlugin failed on "/xx/xx/libdxcb.so" 

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeid(decltype(obj)).name()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不打印了,仅仅打印地址。。

If the object does not implement `QDebug operator<<(QDebug , const Object *)`
it cannot be printed with QDebug
deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Feb 20, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#233
@kegechen kegechen changed the title chore: only log object type name chore: avoid build error Feb 20, 2024
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComixHe, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
kegechen merged commit cc2b473 into linuxdeepin:master Feb 22, 2024
FeiWang1119 pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Mar 5, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#233
gfdgd-xi pushed a commit to GXDE-OS/dde-qt5platform-plugins that referenced this pull request Jun 10, 2026
* feat: add animation for menu's selected backgroud

Add a ChameleonAnimation class for the geometry translate animation.

* chore: 更新滚动条样式,适配动画 (linuxdeepin#233)

更新滚动条样式,适配动画

Log:

* chore: add round and remove shadow for menu item

add round and remove shadow for menu item

Log:

* chore: 更改checkbox和radio实现方式为dci图标,增加动效 (linuxdeepin#236)

更改checkbox和radio实现方式为dci图标,增加动效

Log:

* fix: adjust progressbar color (linuxdeepin#237)

adjust progressbar color

Log:

* fix: 修复在选中框之外hover 和点击也有动画的问题 (linuxdeepin#238)

checkbox和radio有框选区和文字区,应该只对框选区事件做处理

Log:

---------

Co-authored-by: JiDe Zhang <zhangjide@deepin.org>
Co-authored-by: wangfei <wangfei@deepin.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants