Skip to content

feat(shortcut): add tile_left and tile_right actions - #82

Merged
wineee merged 1 commit into
linuxdeepin:masterfrom
glyvut:master
Jul 31, 2026
Merged

feat(shortcut): add tile_left and tile_right actions#82
wineee merged 1 commit into
linuxdeepin:masterfrom
glyvut:master

Conversation

@glyvut

@glyvut glyvut commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Add tile_left and tile_right entries to the action enum in the treeland-shortcut-manager-v2 protocol.

在 treeland-shortcut-manager-v2 协议的 action 枚举中新增
tile_left 和 tile_right 平铺窗口动作。

Log: 新增窗口分屏快捷动作
PMS: BUG-365891
Influence: 快捷键管理协议新增窗口左右平铺动作以支持分屏。

Summary by Sourcery

New Features:

  • Introduce tile_left and tile_right action enum entries to support window tiling shortcuts.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @glyvut, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds two new window tiling shortcut actions (tile_left and tile_right) to the treeland-shortcut-manager-v2 protocol action enum.

File-Level Changes

Change Details Files
Extend shortcut action enum to support left/right window tiling actions.
  • Introduce tile_left action with numeric value 28 in the action enum.
  • Introduce tile_right action with numeric value 29 in the action enum.
xml/treeland-shortcut-manager-v2.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Comment thread xml/treeland-shortcut-manager-v2.xml Outdated
Add tile_left and tile_right entries to the action enum in the
treeland-shortcut-manager-v2 protocol.

在 treeland-shortcut-manager-v2 协议的 action 枚举中新增
tile_left 和 tile_right 平铺窗口动作。

Log: 新增窗口分屏快捷动作
PMS: BUG-365891
Influence: 快捷键管理协议新增窗口左右平铺动作以支持分屏。
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码正确新增了窗口平铺快捷键枚举项并升级了协议版本,符合Wayland协议扩展规范
逻辑清晰,语法正确,无任何安全漏洞或性能问题

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修改位于 xml/treeland-shortcut-manager-v2.xml 中,将 treeland_shortcut_manager_v2 接口的 version 属性从 2 更新至 3,并在对应的枚举中新增了 tile_left (value=28) 和 tile_right (value=29) 两个条目,同时正确指定了 since="3" 属性。XML 结构闭合正确,属性值符合Wayland协议规范。
潜在问题:无
建议:无

  • 2.代码质量(优秀)✓

新增的枚举项命名 tile_lefttile_right 简洁明了,符合现有的命名风格(如 taskswitch_prev)。版本号与 since 属性保持一致,体现了良好的向后兼容性设计。
潜在问题:无
建议:无

  • 3.代码性能(无性能问题)✓

本次修改仅为协议接口定义文件的扩展,不涉及实际算法逻辑或运行时资源消耗,对系统性能无任何负面影响。
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅涉及XML配置文件中枚举值的增加,不包含任何可执行逻辑、外部输入处理或内存操作,不存在攻击面。

  • 建议:无需修复

■ 【改进建议代码示例】

// 代码已完全符合规范,无需修改

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glyvut, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wineee
wineee merged commit 9ccdeb6 into linuxdeepin:master Jul 31, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants