fix: update Chinese location rule patterns#364
Merged
Conversation
1. Added "文档库" (document library) to documents directory patterns 2. Added "相册里" (in the album) and "图片库" (picture library) to pictures directory patterns 3. These changes expand the search matching for common Chinese user expressions regarding document and picture locations Influence: 1. Test Chinese language searches containing new pattern terms 2. Verify search results for document and picture locations match expectations 3. Check behavior with mixed old and new pattern terms fix: 更新中文位置规则匹配模式 1. 在文档目录模式中增加了"文档库" 2. 在图片目录模式中增加了"相册里"和"图片库" 3. 这些变更扩展了对中文用户常见文档和图片位置表达式的搜索匹配 Influence: 1. 测试包含新模式术语的中文搜索 2. 验证文档和图片位置的搜索结果是否符合预期 3. 检查新旧模式术语混合使用时的行为 Fixes: #370933 #370937
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Chinese location rule patterns to broaden matching of common user expressions for document and picture directories by extending the relevant pattern lists in the zh_CN semantic rules JSON. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For the new Chinese patterns like "文档库", "相册里" and "图片库", please double-check they’re classified under the correct intent/slot so they don’t inadvertently match non-directory contexts (e.g., generic text mentioning a library or album).
- Consider whether these added patterns should also include common variants (e.g., with/without spaces or punctuation, simplified colloquial forms) to avoid partial coverage that might lead to inconsistent matching for similar queries.
- If the location rules use any priority or weighting, verify the insertion point of the new patterns so they don’t overshadow more specific rules or change the ranking behavior for existing queries.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the new Chinese patterns like "文档库", "相册里" and "图片库", please double-check they’re classified under the correct intent/slot so they don’t inadvertently match non-directory contexts (e.g., generic text mentioning a library or album).
- Consider whether these added patterns should also include common variants (e.g., with/without spaces or punctuation, simplified colloquial forms) to avoid partial coverage that might lead to inconsistent matching for similar queries.
- If the location rules use any priority or weighting, verify the insertion point of the new patterns so they don’t overshadow more specific rules or change the ranking behavior for existing queries.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pictures directory patterns
expressions regarding document and picture locations
Influence:
expectations
fix: 更新中文位置规则匹配模式
Influence:
Fixes: #370933 #370937
Summary by Sourcery
Expand Chinese location rule patterns for document and picture directories to cover more common user expressions.
New Features:
Tests: