Unicron fix cla email template

[lukaszgryglicki]

This fixes issue with email template project name name reported on slack: https://linuxfoundation.slack.com/archives/C0697E1QHNG/p1784294344570839

Signed-off-by: Łukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Assisted by Claude

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d15b2b4b-462f-4f71-9a05-c8c1302fd978

📥 Commits

Reviewing files that changed from the base of the PR and between f169f50 and b92a94b.

📒 Files selected for processing (4)

• cla-backend-go/emails/docusign_templates.go
• cla-backend-go/emails/docusign_templates_test.go
• cla-backend-go/emails/prefill_test.go
• cla-backend-go/v2/sign/service.go

---

Walkthrough

Signed CLA email rendering now selects project or CLA-group template data based on model version. Signed ICLA and CCLA templates render the corresponding name, callbacks pass the project ID, and tests cover lookup behavior and errors.

Changes

Signed CLA email rendering

Layer / File(s)	Summary
Version-aware template rendering cla-backend-go/emails/docusign_templates.go	Signed ICLA and CCLA templates conditionally reference the project or CLA Group name, while rendering selects version-appropriate template parameters.
Signature callback integration cla-backend-go/v2/sign/service.go	GitHub, GitLab, and Gerrit callbacks pass signature.ProjectID to the renderer.
Lookup and parameter validation cla-backend-go/emails/docusign_templates_test.go, cla-backend-go/emails/prefill_test.go	Tests verify version-specific lookups, rendered content, corporate-console selection, authoritative CLA-group data, and error propagation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SignatureCallback
  participant RenderDocumentSignedTemplate
  participant EmailTemplateService
  participant SignedCLATemplate
  SignatureCallback->>RenderDocumentSignedTemplate: pass CLA group ID and project SFID
  RenderDocumentSignedTemplate->>EmailTemplateService: fetch version-specific template parameters
  EmailTemplateService-->>RenderDocumentSignedTemplate: return project or CLA group data
  RenderDocumentSignedTemplate->>SignedCLATemplate: render signed CLA email

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title references the CLA email template fix and matches the main change, despite being slightly noisy.
Description check	✅ Passed	The description is directly related to the email template project-name fix described in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch unicron-fix-cla-email-template

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Updates DocuSign completion emails to identify the correct CLA Group instead of an unrelated project.

Changes:

• Uses CLAGroupName in ICLA and CCLA signed-document templates.
• Adds regression tests for both templates.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
cla-backend-go/emails/docusign_templates.go	Corrects the displayed entity name.
cla-backend-go/emails/docusign_templates_test.go	Verifies CLA Group rendering.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

[lukaszgryglicki]

This is ready for review @ahmedomosanya @mlehotskylf @WillsonHG

[ahmedomosanya]

LGTM