Skip to content

Force pillow version to 9.5 - #106

Closed
codingismy11to7 wants to merge 2 commits into
linuxserver:masterfrom
codingismy11to7:force_pillow_version
Closed

Force pillow version to 9.5#106
codingismy11to7 wants to merge 2 commits into
linuxserver:masterfrom
codingismy11to7:force_pillow_version

Conversation

@codingismy11to7

Copy link
Copy Markdown

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

There are various crashes in the embedart plugin, as it's not compatible with Pillow 10. The worst of these blocks every import, since it's using parameters to resize images that don't exist in the code anymore.

I feel like the images should probably install ImageMagick instead of falling back to pillow, but I don't have a way to test the non-x86 image.

Benefits of this PR and context:

How Has This Been Tested?

I manually rolled back to pillow 9.5 on my image, which allows imports to continue without crashing

Source / References:

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/beets/1.6.0-pkg-306e3a75-dev-14fc29ae803e4d332e7b090aa722ac2a3d9d46c8-pr-106/index.html
https://ci-tests.linuxserver.io/lspipepr/beets/1.6.0-pkg-306e3a75-dev-14fc29ae803e4d332e7b090aa722ac2a3d9d46c8-pr-106/shellcheck-result.xml

Tag Passed
amd64-1.6.0-pkg-306e3a75-dev-14fc29ae803e4d332e7b090aa722ac2a3d9d46c8-pr-106
arm64v8-1.6.0-pkg-306e3a75-dev-14fc29ae803e4d332e7b090aa722ac2a3d9d46c8-pr-106

@LinuxServer-CI

Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@codingismy11to7

Copy link
Copy Markdown
Author

putting a comment so maybe it won't be marked as stale anymore?

I've taken to publishing my own image (but have to manually update it, would be good if upstream worked). but like I said in the original PR text, pinning pillow or installing imagemagick both fix it. imagemagick is actually the preferred image resizing solution in the beets code, so that's what i'm using in my image, but it does increase the image size significantly (and i assume it's available for arm, but don't know).

@thespad

thespad commented Aug 21, 2023

Copy link
Copy Markdown
Member

Imagemagick is about 100Mb extra, but https://github.com/linuxserver/docker-mods/tree/universal-package-install is an option if it's preferred.

I've finally had time to look at our broken 3.18 rebase PRs, fix them, and include your changes from this PR. I'm going to try and get them merged today.

@thespad

thespad commented Aug 21, 2023

Copy link
Copy Markdown
Member

Going to see what I can do with Imagemagick instead of Pillow and the nightly branch, it'll add about 70Mb to the image so but that's perfectly workable if it provides significant benefits.

@thespad

thespad commented Aug 21, 2023

Copy link
Copy Markdown
Member

Any chance you could give lspipepr/beets:nightly-684fab47-pkg-534270fb-dev-e30bd93894552854a35b0f8164f512fd63219782-pr-104 a spin and see how it works for you?

@bossanova808

Copy link
Copy Markdown

Not the OP and by no means an exhaustive test, but I changed my docker compose from an older image that was from before issues with PIL to yours:

        #image: ghcr.io/linuxserver/beets:nightly-c948c0f6-ls293
        image: lspipepr/beets:nightly-684fab47-pkg-534270fb-dev-e30bd93894552854a35b0f8164f512fd63219782-pr-104 

...and I just processed an album without the artwork errors I was getting from all the recent 'latest' images.

@thespad

thespad commented Aug 25, 2023

Copy link
Copy Markdown
Member

Stable branch is now pinned to Pillow 9.5.0, nightly is using Imagemagick. If/when there's a new upstream stable release we'll roll Imagemagick into that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants