chore: use ThrowsPromise helper across agent package - #1249
Merged
Conversation
🦋 Changeset detectedLatest commit: 994d83a The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
marked this pull request as ready for review
April 14, 2026 12:28
lukasIO
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…nto lukas/throws-promise
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
toubatbrian
reviewed
Apr 14, 2026
Comment on lines
+128
to
+129
| export class Future<T = void, E extends Error = Error> { | ||
| #await: ThrowsPromise<T, E>; |
Contributor
There was a problem hiding this comment.
Having error typed Future is really nice!
toubatbrian
reviewed
Apr 14, 2026
| this.#session!.on('open', resolve); | ||
| this.#session!.on('error', (error) => reject(error)); | ||
| this.#session!.on('close', (code) => reject(`WebSocket returned ${code}`)); | ||
| this.#session!.on('close', (code) => reject(new Error(`WebSocket returned ${code}`))); |
Contributor
Author
There was a problem hiding this comment.
the asError helper is primarily meant to turn unknown catch values into an error at best effort. Constructing the error here is fine, I think
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.