Skip to content

chore: stop gitignoring plugin CHANGELOG.md files - #1519

Merged
toubatbrian merged 1 commit into
mainfrom
brian/add-changelog
May 15, 2026
Merged

chore: stop gitignoring plugin CHANGELOG.md files#1519
toubatbrian merged 1 commit into
mainfrom
brian/add-changelog

Conversation

@toubatbrian

@toubatbrian toubatbrian commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The blanket *.md rule in .gitignore (added in #811 on 2025-11-14) has no negation for CHANGELOG.md. Plugins that already existed when the rule landed had their CHANGELOG.md tracked at the time, so git keeps updating those files. Every plugin added after 2025-11-14 has its generated CHANGELOG.md silently dropped by git add during the release commit.

This cascades into two release-side bugs:

  1. No GitHub release gets created. changesets/action's createRelease reads CHANGELOG.md from disk to build the GitHub release body. For untracked plugins it hits ENOENT and silently returns — npm publish still goes out, but no GitHub release ever appears.
  2. Release notes for @livekit/agents lose attribution. When a PR's changeset is scoped only to a plugin (e.g. feat(assemblyai): new STT plugin for Universal-Streaming (v3) #1219@livekit/agents-plugin-assemblyai), the descriptive entry only lives in that plugin's CHANGELOG. With the file gitignored, the description never reaches main, and agents/CHANGELOG.md only gets the bare "Updated dependencies" line from the fixed-group bump — so the PR shows up nowhere in the published release notes. That's why feat(assemblyai): new STT plugin for Universal-Streaming (v3) #1219 is missing from the @livekit/agents@1.2.7 release notes even though it's listed in the version-packages PR (Version Packages #1233).

Affected plugins (added after the rule landed): assemblyai, baseten, cerebras, fishaudio, hedra, hume, inworld, lemonslice, liveavatar, minimax, mistral, mistralai, phonic, runway, sarvam, trugen, xai.

Fix

Add !**/CHANGELOG.md to .gitignore. From the next `Version Packages` PR onward, the regenerated CHANGELOG files for these plugins will actually be committed, giving them GitHub releases and proper release-note attribution.

Note on backfill

Historical 1.2.x–1.4.x GitHub releases for the affected plugins won't be created retroactively by this fix — the original .changeset/*.md source files for those versions were already consumed. If the docs scraper needs them, we'd have to reconstruct entries from PR titles + commit history and create the releases via the GitHub API in a separate pass.

Test plan

  • On the next release, verify the Version Packages commit on `main` includes new `plugins//CHANGELOG.md` files.
  • On the next release, verify GitHub releases get created for all affected plugin packages.

Made with Cursor

The blanket `*.md` rule (added in #811) had no negation for
`CHANGELOG.md`, so every plugin added after 2025-11-14 had its
generated CHANGELOG silently dropped by `git add` during the release
commit. This cascaded into two release-side bugs:

1. `changesets/action`'s `createRelease` reads `CHANGELOG.md` from
   disk to build the GitHub release body. For untracked plugins it
   hits ENOENT and silently returns, so no GitHub release ever gets
   created (npm releases still go out fine).
2. When a PR's changeset is scoped only to a plugin (e.g. #1219 →
   `@livekit/agents-plugin-assemblyai`), the descriptive entry only
   lives in that plugin's CHANGELOG. With the file gitignored, the
   description never reaches `main`, and `agents/CHANGELOG.md` is
   left with just the "Updated dependencies" line from the fixed-
   group bump — so the PR shows up nowhere in the release notes.

Affected plugins (added after the rule landed): assemblyai, baseten,
cerebras, fishaudio, hedra, hume, inworld, lemonslice, liveavatar,
minimax, mistral, mistralai, phonic, runway, sarvam, trugen, xai.

Adding `!**/CHANGELOG.md` lets the next `Version Packages` PR commit
the regenerated CHANGELOG files for these plugins so they get GitHub
releases and full release-note attribution from the next cycle on.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented May 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9edef9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@toubatbrian
toubatbrian merged commit 1bba6a7 into main May 15, 2026
8 checks passed
@toubatbrian
toubatbrian deleted the brian/add-changelog branch May 15, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants