Skip to content

ci(deploy-examples): fetch LFS assets - #1718

Merged
toubatbrian merged 1 commit into
ethnic-borax-cudfrom
port-examples-deploy-lfs
Jun 5, 2026
Merged

ci(deploy-examples): fetch LFS assets#1718
toubatbrian merged 1 commit into
ethnic-borax-cudfrom
port-examples-deploy-lfs

Conversation

@rosetta-livekit-bot

@rosetta-livekit-bot rosetta-livekit-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Problem

Deployed examples crash at runtime when they use a Git-LFS-tracked asset that lives in the example directory. The drive-thru agent fails with:

av.error.InvalidDataError: [Errno 1094995529] Invalid data found when processing input: ''
... in livekit-agents/.../utils/codecs/decoder.py, _decode_loop -> av.open(...)

Root cause

examples/drive-thru/agent.py loads bg_noise.mp3 via BackgroundAudioPlayer, and *.mp3 is Git-LFS tracked. The deploy path is:

  1. actions/checkout runs without lfs: true → the workspace holds a 131-byte LFS pointer instead of the real MP3.
  2. lk agent deploy . uploads that example dir as the build context.
  3. The Dockerfile's COPY . . copies the pointer into the image.
  4. At runtime BackgroundAudioPlayer hands the 131-byte pointer text to the decoder, which calls av.open(..., format="mp3") → FFmpeg rejects it → InvalidDataError.

This is distinct from the silero VAD onnx issue: that asset arrives via pip's git clone of the SDK (which can't fetch LFS anonymously, so it's kept on PyPI). bg_noise.mp3 instead
arrives via the checkout workspace → COPY . ., so it has to be fixed at the checkout step.

Fix

Add lfs: true to the actions/checkout step. The checkout authenticates with GITHUB_TOKEN, so its LFS fetch is allowed (unlike pip's anonymous clone) and the real binaries are
materialized before lk agent deploy uploads the build context.

  • uses: actions/checkout@...v6
    with:
    ref: ${{ inputs.ref || github.ref }}
    lfs: true

Scope / notes

  • Fixes any example-local LFS asset, not just drive-thru.
  • Built-in livekit-agents/.../resources/*.ogg background clips are not covered here — they ship inside the git-installed SDK and would need a separate fix (e.g. publishing them in the
    wheel) if a deployed example uses a built-in clip.

Testing

  • Manually dispatch Deploy Examples from this branch and confirm the drive-thru agent starts and plays background audio without the InvalidDataError.

@changeset-bot

changeset-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7ad7e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@toubatbrian
toubatbrian merged commit 31d0077 into ethnic-borax-cud Jun 5, 2026
2 checks passed
@toubatbrian
toubatbrian deleted the port-examples-deploy-lfs branch June 5, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant