refactor(voice): extract shared forwardedTextFor helper - #1918
Merged
ShayneP merged 1 commit intoJun 30, 2026
Merged
Conversation
Hoist the per-segment forwarded-text logic into a single forwardedTextFor helper (mirroring Python's _ForwardOutput.forwarded_text) used by both the pipeline and realtime reply paths, replacing the duplicated inline logic. Introduce a shared ForwardOutput interface backing SegmentOutput and MessageOutput.
|
ShayneP
merged commit Jun 30, 2026
dfe9dfb
into
fix/phantom-utterance-interrupted-transcript
1 of 2 checks passed
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the interrupted-speech forwarded-text logic introduced in #1916 into a single shared
forwardedTextForhelper used by both the pipeline and realtime reply paths, mirroring Python's_ForwardOutput.forwarded_text.Changes Made
forwardedTextForhelper ingeneration.ts, typed on a sharedForwardOutputinterfaceSegmentOutputandMessageOutputwithForwardOutput, dropping the duplicated inline forwarded-text logic in both reply pathsPre-Review Checklist
Testing
agent_activity_interrupted_commit.test.tsfrom fix(voice): commit interrupted speech without a synchronized transcript #1916)Additional Notes
Stacked on top of #1916 — base is
fix/phantom-utterance-interrupted-transcript. Pure refactor, no behavior change.