Skip to content

standardize language handling - #4926

Merged
davidzhao merged 10 commits into
mainfrom
dz/unify-language
Feb 26, 2026
Merged

standardize language handling#4926
davidzhao merged 10 commits into
mainfrom
dz/unify-language

Conversation

@davidzhao

Copy link
Copy Markdown
Member

use a uniform Language class to unify how we handle language coding across the core framework and plugins.

the framework will always reference Language type internally, where each plugin then converts it to a specific type as needed by external services.

use a uniform Language class to unify how we handle language coding
across the core framework and plugins
@davidzhao
davidzhao requested a review from a team February 23, 2026 17:49
devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread livekit-agents/livekit/agents/inference/stt.py
Comment thread livekit-agents/livekit/agents/_language_data.py
devin-ai-integration[bot]

This comment was marked as resolved.

@longcw longcw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! something nit:

Comment thread livekit-plugins/livekit-plugins-elevenlabs/livekit/plugins/elevenlabs/stt.py Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 23 additional findings in Devin Review.

Open in Devin Review

@davidzhao
davidzhao merged commit fb1c62f into main Feb 26, 2026
17 of 18 checks passed
@davidzhao
davidzhao deleted the dz/unify-language branch February 26, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants