Skip to content

fix: add timeout to _shutting_down_fut await in SupervisedProc.aclose()#5811

Open
svacatalisan wants to merge 2 commits into
livekit:mainfrom
svacatalisan:process_shutdown_dead_lock
Open

fix: add timeout to _shutting_down_fut await in SupervisedProc.aclose()#5811
svacatalisan wants to merge 2 commits into
livekit:mainfrom
svacatalisan:process_shutdown_dead_lock

Conversation

@svacatalisan
Copy link
Copy Markdown
Contributor

Without a timeout, aclose() hangs indefinitely if the child process acks shutdown but never sends ShuttingDown (e.g. session.aclose() gets stuck). This wraps the await with wait_for(close_timeout) and kills the process on timeout, making the shutdown sequence fully bounded.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


svacatalisan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants