-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix(realtime): surface pending-reply drop on reconnect via SpeechHandle.exception() #6436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ByteMaster-1
wants to merge
3
commits into
livekit:main
Choose a base branch
from
ByteMaster-1:fix/pending-reply-drop-on-reconnect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
4fae685
fix(realtime): surface pending-reply drop on reconnect via SpeechHand…
ByteMaster-1 d8ac123
fix(realtime): also route say() reconnect discard to SpeechHandle.exc…
ByteMaster-1 2d32aaf
Merge branch 'main' into fix/pending-reply-drop-on-reconnect
ByteMaster-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the only change of this pr is replace the
RealtimeErrorwithAPIConnectionErrorhere, what is the purpose for that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type swap is the mechanism; the goal is making the reconnect drop actionable for the application.
On a transient socket drop, _reconnect() discards the pending generate_reply future and never re-creates the response — so the turn silently produces nothing. That discard already reaches SpeechHandle.exception() (via the #6304 plumbing), but as a bare RealtimeError it's indistinguishable from a terminal failure like "realtime session closed". An app that wants to re-prompt only on a transient drop would have to string-match the message.
APIConnectionError carries retryable=True, so the app can branch on the same taxonomy the rest of the SDK already uses — no new types, no string matching:
exc = handle.exception()
if isinstance(exc, APIError) and exc.retryable:
# transient reconnect drop — safe to re-prompt
This is exactly the retryable-flag contract #6352 introduced in this same file for fatal errors (retryable=False) — this PR completes the other half for the transient case. The terminal "realtime session closed" path deliberately stays a bare RealtimeError, since there's nothing to retry against.
This is the follow-up we agreed on in the #6352 review ("yes we can make the drop on reconnect inside the plugin observable via SpeechHandle.exception()").