Deprecate sandbox token server and use development token server - #366
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MaxHeimbrock
marked this pull request as ready for review
July 31, 2026 12:25
MaxHeimbrock
requested review from
cloudwebrtc,
ladvoc and
xianshijing-lk
as code owners
July 31, 2026 12:25
The concrete implementations are now private sealed classes nested in the static TokenSource factory, so construction is only possible through the factory methods, which return ITokenSourceFixed or ITokenSourceConfigurable. The development token server is a preconfigured endpoint source; the deprecated SandboxTokenServer method forwards to it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
TokenSourceLiteral, TokenSourceCustom, TokenSourceEndpoint and TokenSourceSandbox remain publicly constructible but are marked [Obsolete], pointing to the TokenSource factory methods. They are thin wrappers delegating to the private implementations, matching the constructor signatures shipped in v2.0.0 (including the nested CustomTokenFunction delegate and the TokenSourceSandbox inheritance from TokenSourceEndpoint). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lukasIO
reviewed
Aug 4, 2026
lukasIO
approved these changes
Aug 4, 2026
xianshijing-lk
approved these changes
Aug 4, 2026
xianshijing-lk
left a comment
xianshijing-lk
left a comment
Contributor
There was a problem hiding this comment.
some questions, lgtm assuming you will be addressing them
| /// </summary> | ||
| public static class TokenSource | ||
| { | ||
| public delegate Task<ConnectionDetails> CustomTokenFunction(); |
Contributor
There was a problem hiding this comment.
should we make such CustomTokenFunction cancellable ?
Contributor
Author
There was a problem hiding this comment.
That would need a lot more work and in JS we also don't offer that. Maybe something to keep in mind for the future or when customers request it.
…TP objects - Make private token source fields readonly - Copy endpoint headers into an IReadOnlyList at construction so later mutation of the caller's collection (e.g. the component's serialized list) no longer leaks into requests - Dispose HttpRequestMessage and HttpResponseMessage via using var Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Deprecating "Sandbox" token source and renaming it to development token source.
Changes
TokenSourceSandboxeverywhereTokenSourceDevelopmentNewer changes: