Simplify number matching rules. Make '+' optional.#737
Merged
Conversation
🦋 Changeset detectedLatest commit: 31369d9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
biglittlebigben
approved these changes
Jun 12, 2024
b9a523c to
31369d9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a few support questions from customers regarding SIP are made because of a tiny mistake in the number format in their Trunks. Twilio requires leading
+, while Telnyx omits it by default.This change makes
+always optional for inbound calls. We will still accept the call if the Trunk has+set, butINVITEomits it (and vise versa).In addition, make effort to fix outbound calls (
CreateSIPParticipantrequests) too by checking the base domain in SIP URI. It's not perfect and won't work if provider changes the domain. But it will help avoid most common problems.