-
Notifications
You must be signed in to change notification settings - Fork 207
livekit-ffi migration, phase 0 #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhugman
wants to merge
2
commits into
main
Choose a base branch
from
jhugman/ffi-migration-0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Copyright 2025 LiveKit, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| /// Returns the version specified in the crate's Cargo.toml. | ||
| /// | ||
| /// This is the first function exposed over UniFFI from `livekit-ffi`. It carries | ||
| /// no server state and touches no handle store, so downstream SDKs can call it to | ||
| /// prove the UniFFI bindgen toolchain is wired up end-to-end. | ||
| #[uniffi::export] | ||
| pub fn build_version() -> String { | ||
| env!("CARGO_PKG_VERSION").to_string() | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::build_version; | ||
|
|
||
| #[test] | ||
| fn build_version_matches_cargo_pkg_version() { | ||
| assert_eq!(build_version(), env!("CARGO_PKG_VERSION")); | ||
| assert!(!build_version().is_empty()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| [package] | ||
| name = "bindgens" | ||
| version = "0.1.0" | ||
| edition.workspace = true | ||
| license.workspace = true | ||
| repository.workspace = true | ||
| description = "Foreign-binding generator CLIs for the LiveKit Rust crates" | ||
| publish = false | ||
|
|
||
| # Tooling crate: each bin is a code-generation CLI shared across the workspace's | ||
| # uniffi-exposing crates (livekit-ffi, livekit-uniffi, ...). It has no library | ||
| # target — the bindgens read metadata from an already-compiled cdylib via | ||
| # `--library`, so they never depend on the crates they generate for. | ||
| [dependencies] | ||
| uniffi = { workspace = true, features = ["cli"] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Copyright 2025 LiveKit, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //! The UniFFI bindgen CLI, shared across the workspace. | ||
| //! | ||
| //! Generate bindings from any compiled uniffi cdylib, e.g.: | ||
| //! `cargo run -p bindgens --bin uniffi-bindgen -- generate \ | ||
| //! --library target/debug/liblivekit_ffi.dylib --language python --out-dir <dir>` | ||
| fn main() { | ||
| uniffi::uniffi_bindgen_main() | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Release notes entry missing for the version-reporting change
The change adds new functionality to the FFI package without adding the required release-notes file (no new entry alongside the existing ones in
/.changeset), so the affected package will not be version-bumped or documented on release.Impact: The new capability ships without a version bump or changelog entry, so consumers can't tell which release contains it.
Repository rule: every PR must include a changeset listing crates to bump
AGENTS.md ("Documenting changes") states: "Every PR needs a changeset" and "Changeset must list any crates which need to be bumped stemming from the change". This PR adds
livekit-ffi/src/build_info.rs(a new publicbuild_versionUniFFI export) plus a newtools/bindgenscrate, but/.changesetonly contains the three pre-existing files (fix-publisher-renegotiation-deadlock.md,fix_nvenc_dynamic_bitrate_updates.md,fix_uniffi_android_package_build.md). A new changeset markinglivekit-ffishould be added.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.