Ignore duplicate CreateSIPParticipant request from sdk retry - #750
Open
cnderrauber wants to merge 1 commit into
Open
Ignore duplicate CreateSIPParticipant request from sdk retry#750cnderrauber wants to merge 1 commit into
cnderrauber wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
hechen-eng
requested changes
Jul 24, 2026
hechen-eng
left a comment
hechen-eng
left a comment
Contributor
There was a problem hiding this comment.
We don't dedup for CreateSIPParticipant today and I think it's a gap we need to fill. There are a couple problems with this PR though:
- not tested.. e.g. is req.Token enough for GetParticipant?
- what if WsUrl is missing?
- do we want to create a new LiveKitAPI per call?
- no timeouts
- what if a retry arrives before we can see the participant?
- waitUntilAnswered may be broken since it returns immeidately
- ...
I think dedup should be handled by sip itself, not querying the ws url to get participant. They are two separate systems and there are consistency issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.