Skip to content

reduce log level of a few low-value logs #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzhao merged 4 commits into from
Jul 31, 2026
Merged

reduce log level of a few low-value logs #752

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8cb527
reduce dtmf logs to debug
davidzhao Jul 19, 2026
a5bd90b
also reducing level of other low-value logs
davidzhao Jul 19, 2026
024cf0a
Merge branch 'main' into dz/dtmf-debug-log
davidzhao Jul 22, 2026
7ce3195
keep codec log
davidzhao Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/sip/media_port.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (c *udpConn) SetDst(addr netip.AddrPort) {
if addr.IsValid() {
prev := c.dst.Swap(&addr)
if prev == nil || !prev.IsValid() {
c.log.Infow("setting media destination", "addr", addr.String())
c.log.Debugw("setting media destination", "addr", addr.String())
} else if *prev != addr {
changeCount := c.dstChangeCount.Add(1)
now := time.Now().UnixNano()
Expand All @@ -263,7 +263,7 @@ func (c *udpConn) Read(b []byte) (n int, err error) {
}
prev := c.src.Swap(&addr)
if prev == nil || !prev.IsValid() {
c.log.Infow("setting media source", "addr", addr.String())
c.log.Debugw("setting media source", "addr", addr.String())
} else if *prev != addr {
changeCount := c.srcChangeCount.Add(1)
now := time.Now().UnixNano()
Expand Down Expand Up @@ -318,7 +318,7 @@ func (c *udpConn) discardLoop() error {
packetsDiscarded++
}
if err != nil || packetsDiscarded > 0 {
c.log.Infow("Stopped discarding packets", "packetsDiscarded", packetsDiscarded, "error", err)
c.log.Debugw("Stopped discarding packets", "packetsDiscarded", packetsDiscarded, "error", err)
}
err = c.UDPConn.SetReadDeadline(time.Time{}) // clear deadline
if err != nil && !errors.Is(err, net.ErrClosed) {
Expand Down Expand Up @@ -813,7 +813,7 @@ func (p *MediaPort) rtpLoop(tid traceid.ID, sess rtp.Session) {
p.stats.Streams.Add(1)
p.mediaReceived.Break()
log := p.log.WithValues("ssrc", ssrc)
log.Infow("accepting RTP stream")

@alexlivekit alexlivekit Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one helped us find both these issues out, but once we handle the second one as well this can be a number, no need to log every time.

log.Debugw("accepting RTP stream")
go p.rtpReadLoop(tid, log, r)
}
}
Expand Down
Loading