Skip to content

correctly create directory for path_outputs if not existing#1668

Merged
mashb1t merged 3 commits intolllyasviel:developfrom
mashb1t:bugfix/fix-create-dir-if-not-existing
Feb 25, 2024
Merged

correctly create directory for path_outputs if not existing#1668
mashb1t merged 3 commits intolllyasviel:developfrom
mashb1t:bugfix/fix-create-dir-if-not-existing

Conversation

@mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented Dec 30, 2023

Closes #1077

Currently the config is loaded first and falls back to the default outputs dir if it doesn't exist, then creates the fallback outputs dir... which doesn't make that much sense to me.

Expected:

  1. change config path_outputs to non-existing directory
  2. run Fooocus
  3. path_outputs dir does get created

Actual

  1. change config path_outputs to non-existing directory
  2. run Fooocus
  3. loads config, doesn't find path_outputs dir,m falls back to default value
  4. calls os.makedirs(path_outputs, exist_ok=True) on fallback value
  5. path_outputs dir does not get created

@mashb1t mashb1t requested a review from lllyasviel as a code owner December 30, 2023 18:11
@mashb1t mashb1t added the Size M medium change, isolated, testing with care label Feb 9, 2024
@mashb1t mashb1t added this to the 2.2.0 milestone Feb 24, 2024
@mashb1t mashb1t changed the base branch from main to develop February 25, 2024 17:07
@mashb1t mashb1t merged commit b5f019f into lllyasviel:develop Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size M medium change, isolated, testing with care

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create folder if missing

1 participant