Minor fix#56
Merged
Merged
Conversation
…s with its title.
dylan-copeland
approved these changes
Jun 20, 2025
axla-io
pushed a commit
that referenced
this pull request
Jun 28, 2026
* minor fix * auxiliary train rom as a separate mode * time checking and minor change. still work in progress. * bug fix on SteadyNSSolver::LoadEQPElems * default option for number of supremizer * fixed bug for supremizer basis size * option for interface eqp tolerance * TimeProfiler class * used time profile in rom interface form * used time profiler in interface form * ROMNonlinearForm::GetGradient uses TimeProfiler. * time profiling on rom nonlinear form * rom interface form time profiling * time profiling in DGLaxFriedrichsFluxIntegrator * PrintEQPCoords mode * interface time profiling. * steady NS time profiling * reflecting dylans comments. * bug/warning fixes. * TimeProfile now possesses its own title. At its destruction, it prints with its title.
axla-io
pushed a commit
that referenced
this pull request
Jun 28, 2026
* minor fix * auxiliary train rom as a separate mode * time checking and minor change. still work in progress. * bug fix on SteadyNSSolver::LoadEQPElems * default option for number of supremizer * fixed bug for supremizer basis size * option for interface eqp tolerance * TimeProfiler class * used time profile in rom interface form * used time profiler in interface form * ROMNonlinearForm::GetGradient uses TimeProfiler. * time profiling on rom nonlinear form * rom interface form time profiling * time profiling in DGLaxFriedrichsFluxIntegrator * PrintEQPCoords mode * interface time profiling. * steady NS time profiling * reflecting dylans comments. * bug/warning fixes. * TimeProfile now possesses its own title. At its destruction, it prints with its title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous changes:
ROMHandlernow takes a default value forbasis/number_of_supremizerused for steady NS solver. If each basis does not specify number of supremizers, then the default value is used.SteadyNSSolver::TrainROMEQPElemstakes the input optionmodel_reduction/eqp/interface/relative_tolerance. Interface EQP training can use this tolerance value different from that for domain EQP training.TimeProfilerclass is added for convenient profiling of computation time. This class is now used in:ROMNonlinearFormROMInterfaceFormDGLaxFriedrichsFluxIntegratorInterfaceFormSteadyNSSolverUnsteadyNSSolverprint_eqpis added. Once the EQP training is finished. EQP coordinates for each component can be saved into text files via this mode.