Skip to content

[cmake] Exposes LLVM version number in the runtimes.#84641

Merged
mordante merged 1 commit into
llvm:mainfrom
mordante:review/expose_llvm_version_number_in_runtimes
Mar 11, 2024
Merged

[cmake] Exposes LLVM version number in the runtimes.#84641
mordante merged 1 commit into
llvm:mainfrom
mordante:review/expose_llvm_version_number_in_runtimes

Conversation

@mordante
Copy link
Copy Markdown
Member

@mordante mordante commented Mar 9, 2024

This allows sharing the LLVM version number in libc++.

This allows sharing the LLVM version number in libc++.
@mordante mordante requested review from tru and tstellar March 9, 2024 17:01
@mordante mordante requested a review from a team as a code owner March 9, 2024 17:01
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Mar 9, 2024
@mordante
Copy link
Copy Markdown
Member Author

mordante commented Mar 9, 2024

I originally used this in #81362, there it's not needed anymore. However @ldionne and I feel it would be useful to have this. We probably can use this to set the libc++ version number.

@mordante mordante merged commit 81e2047 into llvm:main Mar 11, 2024
@mordante mordante deleted the review/expose_llvm_version_number_in_runtimes branch March 11, 2024 16:44
@firewave
Copy link
Copy Markdown

I wonder if this could help with #57263.

glandium added a commit to glandium/wasi-sdk that referenced this pull request Mar 12, 2024
abrown pushed a commit to WebAssembly/wasi-sdk that referenced this pull request Mar 12, 2024
@mordante
Copy link
Copy Markdown
Member Author

I wonder if this could help with #57263.

These CMake values were already available to clang-tidy. This made them available for the run-times.

fifield added a commit to Xilinx/mlir-aie that referenced this pull request Apr 3, 2024
fifield added a commit to Xilinx/mlir-aie that referenced this pull request Apr 4, 2024
fifield added a commit to Xilinx/mlir-aie that referenced this pull request Apr 4, 2024
pal1000 added a commit to pal1000/mesa-dist-win that referenced this pull request Oct 18, 2024
fifield added a commit to fifield/mlir-aie that referenced this pull request Nov 12, 2025
Meinersbur added a commit that referenced this pull request Jan 21, 2026
Hoist handling of Doxygen into the top-level cmake/ directory so it can
be shared between LLVM and RUNTIMES and a default/standalone runtimes
build can support building Doxygen documentation as well.

The openmp subproject currently supports doxygen documentation using an
`LLVM_ENABLE_PROJECTS=openmp` build, but not with
`LLVM_ENABLE_RUNTIMES=openmp` because of this missing boilerplate code
in the runtimes build. This is a step towards removing the
`LLVM_ENABLE_PROJECTS=openmp` build mode which was deprecated (#124014)
and already scheduled to be removed in LLVM 21 (#136314). Eventual
removal is planned with #176950.

Hoisting CMake code for shared use with runtimes has been done before in
e.g. #84641, 7017e6c,
44e3365,
7017e6c

---------

Co-authored-by: Petr Hosek <phosek@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake Build system in general and CMake in particular

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants