Add InterlockedAnd tests#1184
Open
bob80905 wants to merge 5 commits into
Open
Conversation
Icohedron
requested changes
May 20, 2026
Comment on lines
+3
to
+6
| // This test exercises InterlockedAnd on 64-bit typed RWBuffer resources. | ||
| // 64-bit atomics on typed UAVs are an optional Shader Model 6.6 capability | ||
| // (D3D12 cap AtomicInt64OnTypedResourceSupported, Vulkan feature | ||
| // shaderBufferInt64Atomics), surfaced to lit as `Int64TypedResourceAtomics`. |
Icohedron
reviewed
May 20, 2026
| # Unimplemented: https://github.com/llvm/llvm-project/issues/99125 | ||
| # XFAIL: Clang | ||
|
|
||
| # REQUIRES: Int64 |
Contributor
There was a problem hiding this comment.
I noticed in this PR you are not adding a REQUIRES: SM_6_6 but in your InterlockedOr PR you are.
Suggested change
| # REQUIRES: Int64 | |
| # REQUIRES: Int64 && SM_6_6 |
Contributor
There was a problem hiding this comment.
There also should be a REQUIRES: Int64GroupSharedAtomics since you're using int64 groupshared variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
InterlockedAndAdds 32 bit and 64 bit signed/unsigned integer tests
Fixes #849