Add geometry shader support with point -> quad test#1203
Open
EmilioLaiso wants to merge 2 commits into
Open
Conversation
EmilioLaiso
force-pushed
the
geometry-shader-point-to-quad-v2
branch
2 times, most recently
from
7a5aac7 to
e5071c0
Compare
manon-traverse
approved these changes
May 21, 2026
Contributor
manon-traverse
left a comment
manon-traverse
left a comment
There was a problem hiding this comment.
Really nice changes! Awesome that we now have geometry shader support :D
bogner
approved these changes
May 21, 2026
Contributor
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
A few minor comments but otherwise LGTM!
Comment on lines
+1785
to
+1786
| else if (Shader.Stage == Stages::Geometry) | ||
| PipelineDesc.GS = std::move(SC); |
Contributor
There was a problem hiding this comment.
Technically this is unreachable, but given that this is the only thing that could possibly make sense here it's probably fine as is.
MarijnS95
reviewed
May 21, 2026
MarijnS95
approved these changes
May 21, 2026
Collaborator
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Once PS is optional on Metal again, this has a thumbs-up from me!
Adds Stages::Geometry, PrimitiveTopology enum and IOBindings::Topology, and a GraphicsPipelineCreateDesc that bundles vertex/geometry/pixel shader containers plus topology, input layout and RT/DS formats. The backends' createPipelineVsPs is replaced by createGraphicsPipeline taking that desc. VK and DX wire an optional geometry stage into the pipeline and pass through PointList topology; Metal has no GS and rejects it at runtime. The new gs_point_to_quad.test expands a single point into a fullscreen quad via a triangle-strip GS. address pr feedback rename to `createTraditionalRasterPipeline`
EmilioLaiso
force-pushed
the
geometry-shader-point-to-quad-v2
branch
from
cd882dd to
4938802
Compare
| llvm::SmallVector<SpecializationConstant> SpecializationConstants; | ||
| }; | ||
|
|
||
| struct GraphicsPipelineCreateDesc { |
Contributor
There was a problem hiding this comment.
Suggested change
| struct GraphicsPipelineCreateDesc { | |
| struct TraditionalRasterPipelineCreateDesc { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add geometry shader support to the engine and introduce
PrimitiveTopologytype.PrimitiveTopologydefaults toTriangleListso that we don't have to specify it in all our existing rasterization tests.Add a new test
Graphics/gs_point_to_quad.testexercising a VS → GS → PS pipeline:Add
GraphicsPipelineCreateDescto keep the pipeline creation function signature tidy.GSandPSwithinGraphicsPipelineCreateDescare optional, but for the time being the backends assert that a PS is set. We can lift that assert once we need a VS-only test.