[api-query] Report GPU driver version#1205
Open
alsepkow wants to merge 3 commits into
Open
Conversation
fae5f69 to
482e8d1
Compare
DriverName on DXThe "Dump GPU Info" CI step runs api-query to log each adapter's API, description, and driver name. Logging the driver version would be useful too when triaging GPU/driver-specific failures, so we have a record of which driver build was in use when a test failed. - Device base class: Add `DriverVersion` member and `getDriverVersion()` getter. - D3D12: Read `DXCoreAdapterProperty::DriverVersion` and decode the packed `LARGE_INTEGER` into `Major.Minor.Build.Revision`. - Vulkan: Read `VkPhysicalDeviceDriverProperties::driverInfo` (vendor- specific human-readable build string, e.g. `26.5.2 (AMD proprietary shader compiler)`). - api-query: Print a new `Driver Version:` line beneath `Driver:`. Sample output: - API: DirectX Description: AMD Radeon RX 6800 Driver Version: 32.0.21043.10005 - API: Vulkan Description: AMD Radeon RX 6800 Driver Version: 26.5.2 (AMD proprietary shader compiler) Assisted by Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
482e8d1 to
f4ee6aa
Compare
Collaborator
Author
|
I realized after that we are saving a dxdiag. That will have the driver version. Still seems convenient to have it logged here IMO though. |
bogner
approved these changes
May 19, 2026
Contributor
bogner
left a comment
There was a problem hiding this comment.
LGTM. See my comment in the other PR about how I feel like the current "DriverName" field is confusingly named.
farzonl
approved these changes
May 19, 2026
`lit.cfg.py` runs api-query and parses stdout with `yaml.safe_load`. `VkPhysicalDeviceDriverProperties::driverInfo` is vendor-specific freeform text and can contain `:` characters. On Qualcomm Adreno it returns e.g. `Driver Build: 6d3eabf20f, Iabbb0663b5, 17528 ...`, which when emitted unquoted produces two `: ` sequences on the same line and trips the YAML scanner with `mapping values are not allowed here`. Emit Driver Version as a double-quoted YAML scalar with `"` and `\` escaped, so colons inside the value are treated as plain text. Assisted by Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes clang-tidy `misc-const-correctness` warning-as-error in CI on configurations that run clang-tidy as part of the build. Assisted by Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
manon-traverse
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Dump GPU Info" step in CI runs
api-queryto log each adapter's API, description, and driver name. Logging the driver version would be useful too when triaging GPU/driver-specific failures, so we have a record of which driver build was in use when a test failed.Changes:
Devicebase class: AddDriverVersionmember andgetDriverVersion()getter.DXCoreAdapterProperty::DriverVersionand decode the packedLARGE_INTEGERintoMajor.Minor.Build.Revision.VkPhysicalDeviceDriverProperties::driverInfo(vendor-specific human-readable build string, e.g."26.5.2 (AMD proprietary shader compiler)").Driver Version:line beneathDriver:.Sample output:
Assisted by Copilot.