Skip to content

Un-XFAIL test now that llvm/llvm-project#144580 is resolved#278

Closed
bogner wants to merge 2 commits into
llvm:mainfrom
bogner:2025-07-08-xpass-144580
Closed

Un-XFAIL test now that llvm/llvm-project#144580 is resolved#278
bogner wants to merge 2 commits into
llvm:mainfrom
bogner:2025-07-08-xpass-144580

Conversation

@bogner

@bogner bogner commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

This test no longer fails because of the original issue, but still has issues
on intel drivers due to llvm/llvm-project#148270

@bogner bogner requested a review from s-perron July 8, 2025 18:15

@s-perron s-perron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can enable this test yet. The problem is that the Intel driver does not support storage images with unknown format. Note that the test will pass if you use a driver that supports this feature, which make the XFAIL awkward.

I need to change the clang compiler to match DXC, and guess at the format. I just opened llvm/llvm-project#148270 to fix this issue.

@bogner

bogner commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

I don't think we can enable this test yet. The problem is that the Intel driver does not support storage images with unknown format. Note that the test will pass if you use a driver that supports this feature, which make the XFAIL awkward.

Updated the XFAIL to just intel since it does pass on other drivers

@hekota

hekota commented Aug 1, 2025

Copy link
Copy Markdown
Member

Uhm, I've accidentally added this change as part of #302. Sorry? :)

@bogner

bogner commented Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

Uhm, I've accidentally added this change as part of #302. Sorry? :)

Yours actually passes the tests so it seems better…

@bogner bogner closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants