Merged
Conversation
BabyChouSr
approved these changes
Dec 16, 2024
| input_data["image_hash"] = input_data.conversation_a.map( | ||
| lambda convo: convo[0]["content"][1][0] | ||
| ) | ||
| input_data["image_path"] = input_data.image_hash.map( |
Collaborator
There was a problem hiding this comment.
Where do we get the image_hash here?
Collaborator
Author
There was a problem hiding this comment.
from the conversation, is the format still [{content: [text, [images]]}?
Collaborator
Author
There was a problem hiding this comment.
I guess the way i have it now doesn't support multi-image
Collaborator
|
I tested out the PR and the leaderboard works well. |
BabyChouSr
reviewed
Dec 16, 2024
Comment on lines
+446
to
+448
| category_name = key_to_category_name[k.replace("_style_control", "")] | ||
| if "_style_control" in k: | ||
| category_name = f"{category_name} w/ Style Control" |
Collaborator
There was a problem hiding this comment.
Sorry, but could you explain what's going on here?
Collaborator
Author
There was a problem hiding this comment.
ah yeah. Based on the previous code logic the stylecontrol leaderboards have the _style_control in their key. Instead of having duplicates for every category name in monitor_md like we have now we add it in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We have been letting language have all the fun for long enough. Vision will rise again. Join the movement.
Checks
format.shto lint the changes in this PR.