ci(docs): remove dead publish workflow; fix spectaql for local docs builds - #442
Merged
Merged
Conversation
Fails on every push to main (red since at least Jun 26, all retained runs) because it commits generated docs to a 'docs' branch that only exists on upstream GaloyMoney/galoy — the fork never created it. Even if it existed, GitHub Pages is not configured on this repo and the spectaql config is still galoy-branded, so the output would serve nothing. 'yarn build-docs' and the spectaql config remain for local use. If we ever want published API docs, that is a small deliberate project: orphan docs branch (or gh-pages), enable Pages, rebrand spectaql-config-template.yml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This reverts commit 767399b.
Instead of deleting the never-working workflow (it pushed to a 'docs' branch that only exists on upstream GaloyMoney/galoy), give it a real destination: generate the spectaql API reference from the checked-in public SDL and publish it into lnflash/flash-docs static/api-reference/, which DO App Platform serves at docs.flashapp.me/api-reference. - Cross-repo push via write deploy key on flash-docs (FLASH_DOCS_DEPLOY_KEY secret, installed) - Rebrand spectaql config: Flash title/contact, real servers (api.flashapp.me + api.test.flashapp.me) - Rebrand TUTORIAL.md endpoints; drop upstream postman link - Path-filter the trigger (schema/spectaql/workflow changes only) + workflow_dispatch; skip publish when output unchanged Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
spectaql 2.3.x fails with 'TypeError: arrangeData is not a function' on Node 20 AND 24 (verified in isolation) — its loose internal deps have drifted; the docs build was broken independently of the publish target. 3.0.9 renders the full rebranded config cleanly (verified against the public SDL: 1.1MB single-file reference, servers + intro items intact). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…flash-api-docs Investigation found docs.flashapp.me is deployed from lnflash/flash-api-docs, which has its own complete pipeline: a daily cron (update-docs.yml) fetches the schema from api.flashapp.me via introspection, regenerates, commits, and deploy.yml ships to DO App Platform via doctl. It had been silently OFF since ~Oct 2025 (GitHub disabled_inactivity after 60 quiet days) — now re-enabled and verified end-to-end. A flash-side publish workflow is therefore redundant; the schema reaches the docs pipeline through live introspection, not git. Kept from this branch: spectaql 2.x->3.0.9 (2.x is package-rotted — fails on Node 20 and 24) and the Flash rebrand of the spectaql config + tutorial, so 'yarn build-docs' works locally again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bobodread876
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the perpetually-red "Generate GraphQL Docs" check on
main— final shape after the full investigation.What we learned (in order)
docsbranch that only exists on upstreamGaloyMoney/galoy— never on this fork.lnflash/flash-api-docs, which has its own complete generation pipeline: daily cron fetches the schema fromapi.flashapp.mevia live introspection → regenerates → commits →deploy.ymlships to DO via doctl.disabled_inactivity(60 quiet days). It was never broken, just unplugged.What this PR does
^2.3.0→^3.0.9— 2.x is package-rotted (arrangeData is not a functionon Node 20 and 24, verified in isolation), soyarn build-docswas broken locally too. 3.0.9 verified against the public SDL.api.flashapp.me+api.test.flashapp.meservers, upstream postman link dropped) so local builds produce Flash-branded output.Done outside this PR (flash-api-docs, already live)
update-docs.ymlre-enabled + dispatched: first schema refresh in 11 months committed (b7d1021)deploy.ymldispatched to ship it (its push-trigger is defeated by the updater's own[skip ci]commits — known quirk, noted for follow-up)flash-docsreverted; temporary deploy key + secret removed🤖 Generated with Claude Code