feat(wallets): map IBEX crypto and taproot transaction types - #455
Merged
Conversation
Type 9 (Crypto Receive — USDT deposits via Bridge) was the row behind the InitiationVia union crash fixed in #454; it and taproot (11/12) now map to on-chain instead of the logged intraledger fallback. Taproot send (12) joins the negate-on-send list. Ids from GET /v2/transaction-types/all: 1/2 LN receive/send, 3/4 on-chain receive/send, 5 Fund, 6 Defund, 7 Bank Deposit, 8 Bank Withdrawal, 9/10 crypto receive/send, 11/12 taproot receive/send. Bank/funding ops (5-8) are org-level and intentionally stay on the logged fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review finding: the sweep proved 5-8 emit resolvable vias but nothing enforced the deliberate decision to keep them on the logged intraledger fallback — a future change could silently map type 8 (Bank Withdrawal) positive-signed with all tests green. Assert each of 5-8 renders as intraledger and logs its transactionTypeId. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bobodread876
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #454. The tripwire it installed fired on prod within minutes:
transactionTypeId: 9— the exact row that used to crash the transaction list.Confirmed against IBEX's own enum (
GET /v2/transaction-types/all, sandbox): 1/2 Lightning receive/send, 3/4 On-Chain receive/send, 5 Fund, 6 Defund, 7 Bank Deposit, 8 Bank Withdrawal, 9 Crypto Receive, 10 Crypto Send, 11/12 Taproot receive/send.IBEX_SEND_TYPE_IDS).Tests
New: crypto-receive (type 9) → on-chain USDT with positive integer cents; taproot receive/send sign behavior. Exhaustive sweep extended to all ids 1–12 + unknown. Full unit suite green (1090),
tsc-checkclean, no schema change.🤖 Generated with Claude Code