bot: check for any falsey value of user in cancelOrder

[webwarrior-ws]

Despite user having type UserDocument | null, there was case [1] of it being undefined, leading to error when reading banned property after merging [2]. So go back to using !user checks that also account for undefined, so function will exit early and not produce an error.

[1] #633 (comment)
[2] #633

Summary by CodeRabbit

• Refactor
  • Improved code readability by simplifying user checks when handling order cancellations. No changes to user-facing behavior.

[coderabbitai]

Walkthrough

The update refactors the cancelOrder function within the bot's command logic. Specifically, it replaces explicit null checks for the user parameter with a single falsy check using !user. This change streamlines the conditional logic for handling cases where the user is not provided or not found, without altering the function's overall behavior or affecting any other parts of the code.

Changes

File(s)	Change Summary
bot/commands.ts	Refactored the cancelOrder function by replacing explicit null checks with a falsy check for user. No other logic was changed.

Poem

In the warren of code, a check was made neat,
Where once was "null", now "falsy" takes the seat.
The bunny hops on, with logic more clear,
No user? No problem—the intent stays near.
With a twitch of the nose and a tap of the key,
Simpler checks make for happier bunnies (and devs), you see!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

bot/commands.ts (1)

585-585: Validate early return branch and add tests
The if (!user) return; guard cleanly exits if the user isn't found. Please add a test case simulating an undefined or null user to ensure this path behaves as expected.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b604b12 and 8e0ebcd.

📒 Files selected for processing (1)

• bot/commands.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ci_to_main
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

bot/commands.ts (1)

578-578: Replace explicit null check with falsy check
Using if (!user) now covers both null and undefined, preventing the previous runtime error when accessing user.banned.

[webwarrior-ws]

Tested cooperative cancellation and it produced no error. Order status was set back to "ACTIVE"

[webwarrior-ws]

Tested cooperative cancellation and it produced no error. Order status was set back to "ACTIVE"

Because of successful testing, this PR is no longer marked as DRAFT.

[Catrya]

tACK thanks @webwarrior-ws

[grunch]

LGTM