fix: republished sell order uses taker's language instead of seller's (#820) - #822
fix: republished sell order uses taker's language instead of seller's (#820)#822franko-c wants to merge 1 commit into
Conversation
…r-cancel When a buyer's invoice times out and the sell order is republished in cancelAddInvoice, publishSellOrderMessage was passed i18nCtx (the canceling taker's context), so the republished order rendered in the taker's language. The seller-cancel path already uses i18nCtxSeller; this mirrors it. Fixes lnp2pBot#820.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR updates the ChangesSeller i18n Context for Order Re-publication
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pr is a duplicate of #821 |
ran into #820 — when a buyer's invoice times out and the sell order gets republished in
cancelAddInvoice,publishSellOrderMessageis handedi18nCtx, which is the canceling taker's context. so the republished order comes back in the taker's language instead of the seller's.the seller-cancel branch at
bot/commands.ts:591already does this right withi18nCtxSeller— this just mirrors that for the buyer-cancel/expiry side.sellerUseris already in scope from the lookup above, so it's a small change.typechecks clean with
tsc --noEmit. happy to adjust if you'd rather thread the context through differently.Summary by CodeRabbit