Skip to content

Fix/review points 6 9#863

Merged
Luquitasjeffrey merged 5 commits into
lnp2pBot:handle_delayed_paymentfrom
Matobi98:fix/review-points-6-9
Jul 7, 2026
Merged

Fix/review points 6 9#863
Luquitasjeffrey merged 5 commits into
lnp2pBot:handle_delayed_paymentfrom
Matobi98:fix/review-points-6-9

Conversation

@Matobi98

@Matobi98 Matobi98 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Addresses the remaining points from grunch's review on #844:

Changes

  • Lint: fix CI lint error (spaced-comment)
  • Point 6: restore backoff on in-flight payment skips — next_retry advances without consuming attempts
  • Point 7: extract shared healConfirmedOrder helper, deduplicating the fail-closed healing routine across all call sites
  • Point 8: move logOrderError to bot/messages.ts as toAdminChannelOrderErrorMessage with i18n template; fix misleading log texts
  • Point 9: allow /paytobuyer on ERROR orders, restricted to superadmins only

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 29c20134-06e4-48f4-95c4-7d454feb7906

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Luquitasjeffrey Luquitasjeffrey merged commit af225d8 into lnp2pBot:handle_delayed_payment Jul 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants