Add ecr support for codebuild #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakkeger
force-pushed
the
allow_ecr_image_use
branch
from
93d8e86 to
f3eb546
Compare
lakkeger
force-pushed
the
allow_ecr_image_use
branch
from
f3eb546 to
ed8ee5c
Compare
lakkeger
force-pushed
the
allow_ecr_image_use
branch
from
d50c8a9 to
27ffdcb
Compare
HarshCasper
approved these changes
May 16, 2024
whummer
approved these changes
May 16, 2024
Member
There was a problem hiding this comment.
Nice catch @lakkeger , LGTM! 🎉 (also added @HarshCasper @lukqw as co-owners of this GH Action to chime in..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeBuild supports GitHub Actions, however often ends with
toomanyrequestserror from Docker Hub, to resolve this issue AWS recommends using their public ECR.