Fix download actions #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ephemeral instance for the application preview has been shut down |
lakkeger
force-pushed
the
fix_finish_comment
branch
3 times, most recently
from
0a342b9 to
0b429c7
Compare
lakkeger
force-pushed
the
fix_finish_comment
branch
from
0b429c7 to
530672a
Compare
lakkeger
force-pushed
the
fix_finish_comment
branch
2 times, most recently
from
199571f to
2d6b15d
Compare
lakkeger
force-pushed
the
fix_finish_comment
branch
from
2d6b15d to
28553e3
Compare
lukqw
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Finish comment sometimes not updated by the new action, instead it's picking up the previous PR comment.
It seems the source of the issue is the download action
dawidd6/action-download-artifact@v2which only picks up successfully concluded workflows by default. As a result the currently running pipeline is not among these instead it's picking the latest successful run on the workflow which can be a different PR.By adding 2 download actions we try to download the artifact first from the current pipeline, if that's not successful we try to download an artifact from the latest successful PR pipeline, if this fails we fail.
Additionally we provide an env variable to override the workflow we're looking for the artifact, however this must be part of the PR.
Changes
PR_ARTIFACT_WORKFLOW