Update actions around ephemeral instances to new api surface #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ephemeral instance for the application preview has been shut down |
lukqw
changed the title
whummer
approved these changes
Jul 15, 2024
ephemeral/startup/action.yml
Outdated
| previewName=preview-$prId | ||
| response=$(curl -X POST -d "{\"auto_load_pod\": \"${AUTO_LOAD_POD:-${{ inputs.auto-load-pod }}}\"}" \ | ||
| response=$(curl -X POST -d "{\"instance_name\": \"${previewName}\", \"env_vars\": {\"AUTO_LOAD_POD\": \"${AUTO_LOAD_POD:-${{ inputs.auto-load-pod }}}\", \"EXTENSION_AUTO_INSTALL\": \"${EXTENSION_AUTO_INSTALL:-${{ inputs.extension-auto-install }}}\"}}"\ |
Member
There was a problem hiding this comment.
nit: This is pretty dense syntax, maybe we could pull the conditional assignment for AUTO_LOAD_POD / EXTENSION_AUTO_INSTALL into temporary variables?
Also, just to confirm - do we want the inputs.* values to be the fallback (if the env variables are not defined), or rather the other way around, i..e, have them overwrite the env. variables, if configured? 🤔
Member
Author
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Moving ephemeral instances to the preview stage has introduced a few changes to the API.
This PR adjusts the actions around ephemeral instances to integrate with those changes.
Testing
I have introduced a separate api key from staging to verify functionality against the currently deployed application on staging.
Before merging this has to be cleaned up again, i.e. switching back to the production api key for the test suite, and calling the production endpoint in the action.
Questions
@lakkeger do I need to add the
extension-auto-installandauto-load-podarguments to the existing root action?