Improve application previews by preventing naming collision #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ephemeral instance for the application preview has been shut down |
lukqw
changed the title
lakkeger
approved these changes
Aug 9, 2024
Contributor
lakkeger
left a comment
lakkeger
left a comment
There was a problem hiding this comment.
LGTM, thanks for tackling it 💯 🎉 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While working on the blog post around ephemeral instances, @remotesynth and @HarshCasper both ran into the same issue:
Pushing two commits in close succession would first yield a successful application preview deployment, while the second commit would run into an error with an
already_existsmessage.This is because the name of the instance was already taken by the first commit and related preview deployment.
Solution
This PR changes the naive approach that was previously used:
Instead of simply calling our creation endpoint, we first detect whether an instance with the same name is already running, and shut it down in case that's true, before starting the instance.