Add initial action to create preview environments from PR builds #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
commented
Sep 28, 2023
lukqw
approved these changes
Sep 29, 2023
Member
lukqw
left a comment
lukqw
left a comment
There was a problem hiding this comment.
Awesome to see that we're pushing this further into the hands of devs 🚀
Member
Author
|
FYI - build error unrelated to this PR, currently being fixed in the context of localstack/localstack#9253 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial Action to create preview environments from PR builds. Note that these features are in internal/beta state at this stage, hence are not exposed in the public docs of this Action.
The PR adds a new
preview/action.ymlfile with an input parameterpreview-cmd, which can be used to define the build steps for the preview environment, using the value inAWS_ENDPOINT_URLas the target endpoint to deploy against.Demo repo here: localstack-samples/bref-localstack-sample#3
See here for the deployment steps in the demo app: https://github.com/whummer/bref-localstack-sample/blob/main/.github/workflows/ci-preview.yml#L21-L33
Side note: Based on these changes, we can further iterate on the functionality, and further streamline this Action in the future. 👍 For example, the
Start LocalStackbuild step is still the main step, but may not be required in all cases. See also theTODOcomment in the mainaction.ymlfile in the repo/cc @lukqw @HarshCasper