Change CoordinateArraySequence to check consistency of array Coordinates rather than fixing

[dr-jts]

Signed-off-by: Martin Davis mtnclimb@gmail.com

[jodygarnett]

Minor feedback, while waiting for tests to run.

[jodygarnett]

testing:

• jts 1.16-SNAPSHOT
• geotools master changing jts.version to 1.16-SNAPSHOT

Initially have an odd failure (actually the build hangs) in gt-coverage:

Exception in thread "SunTileScheduler0Standard1" java.lang.NoSuchMethodError: org.locationtech.jts.geom.Polygon.getExteriorRing()Lorg/locationtech/jts/geom/LineString;
	at it.geosolutions.jaiext.utilities.shape.PolygonIterator.<init>(PolygonIterator.java:61)
	at it.geosolutions.jaiext.utilities.shape.GeomCollectionIterator.getIterator(GeomCollectionIterator.java:92)
	at it.geosolutions.jaiext.utilities.shape.GeomCollectionIterator.init(GeomCollectionIterator.java:65)
	at it.geosolutions.jaiext.utilities.shape.GeomCollectionIterator.<init>(GeomCollectionIterator.java:75)
	at it.geosolutions.jaiext.utilities.shape.LiteShape.getPathIterator(LiteShape.java:245)

Looking at this line I do not see anything amiss:

    public PolygonIterator(Polygon p, AffineTransform at) {
        int numInteriorRings = p.getNumInteriorRing();
        rings = new LineString[numInteriorRings + 1];
        rings[0] = p.getExteriorRing();

@dr-jts indicates the above may be due to #290

[jodygarnett]

Backing out the #290 change I can see failures in downstream projects:

org.geotools.data.DataSourceException: Unable to create this mosaic
    at org.geotools.gce.imagemosaic.ImageMosaicFootprintsTest.testMultipleSidecars(ImageMosaicFootprintsTest.java:276)
    at org.geotools.gce.imagemosaic.ImageMosaicFootprintsTest.testWkbMultipleSidecars(ImageMosaicFootprintsTest.java:220)
Caused by: java.lang.IllegalStateException: Coordinates in array have different types
    at org.geotools.gce.imagemosaic.ImageMosaicFootprintsTest.testMultipleSidecars(ImageMosaicFootprintsTest.java:276)
    at org.geotools.gce.imagemosaic.ImageMosaicFootprintsTest.testWkbMulti

Think a sensible approach would be to:

a) move the method checkCoordainteArray to CoordianteArrays utility class (for reuse)
b) provide a CoordianteArray fix the problem (so client code has an easy fix)

[dr-jts]

This is taken care of by #376