Adding ngChange support#57
Closed
tekand wants to merge 2 commits into
Closed
Conversation
|
Shouldn't be better to add onSubmit and onCancel callbacks? |
Author
|
@tarasichvadim IMO from the app perspective it is completely irrelevant whether the user has clicked on OK or cancel, the app should only care if the value of the field changed. |
|
Any progress on this? Would love to see ng-change supported |
Author
|
Owner seems to be no responsive, you can use my repo as a dependency in the meantime. |
Author
|
@logbon72 ??? |
Owner
|
This has been addressed in previous requests. See #34 |
Owner
|
Apologies for not leaving a comment initially. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #22.
Did not test it deeply and also not made changes to the .min.js version.