Add MDC entry writers to be able to convert values#957
Merged
philsttr merged 3 commits intologfellow:mainfrom Jun 18, 2023
Merged
Add MDC entry writers to be able to convert values#957philsttr merged 3 commits intologfellow:mainfrom
philsttr merged 3 commits intologfellow:mainfrom
Conversation
This was referenced May 19, 2023
philsttr
requested changes
Jun 17, 2023
Collaborator
philsttr
left a comment
philsttr
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I really like the approach you came up with. I have some feedback on naming and some low level implementation details. But in general, the design is solid.
* add protected method to allow manipulating output of MDC entry * change visibility to MDC config attributes
* add LogstashEncoder configuration to add MdcEntryWriters * add MDC entry writers for Long, Double & Boolean values
jug
force-pushed
the
mdc_json_field_converters
branch
from
221b1f0 to
347c6db
Compare
More documentation. Avoid regex for matching long. Use regex recommended by Java for matching doubles. Make some internal methods private .
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
============================================
+ Coverage 71.64% 71.78% +0.14%
- Complexity 1386 1417 +31
============================================
Files 174 177 +3
Lines 5113 5178 +65
Branches 528 534 +6
============================================
+ Hits 3663 3717 +54
- Misses 1189 1197 +8
- Partials 261 264 +3
|
philsttr
approved these changes
Jun 18, 2023
philsttr
changed the title
Collaborator
|
Thanks for the quick turnaround on my review comments! This will be included in the next release (soon) |
This was referenced Jun 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution proposal for issue #955