Set AbstractThrowableClassNameJsonProvider.getThrowable as protected#988
Merged
philsttr merged 1 commit intologfellow:mainfrom Jul 27, 2024
Merged
Set AbstractThrowableClassNameJsonProvider.getThrowable as protected#988philsttr merged 1 commit intologfellow:mainfrom
philsttr merged 1 commit intologfellow:mainfrom
Conversation
Collaborator
|
Looks good. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm trying to customize the
throwable_classfield name but I found out that it isn't possible to extend the classAbstractThrowableClassNameJsonProviderbecause its abstract methodgetThrowableis package protected.I think it doesn't make much sense to have a public abstract class that isn't really publicly extendable. Also this should align the class with the similar
AbstractThrowableMessageJsonProvider, which already has its abstract method as protected.As a temporary workaround I'm extending the class
ThrowableClassNameJsonProvider, this way the package protected method is already implemented and the problem is circumvented.Let me know what you think about this!
Bye!