Round to supported rate before setting temp basal rate#4
Merged
Conversation
marionbarker
approved these changes
Apr 3, 2025
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Based on code review and testing found in LoopKit PR 16, I approve this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors LoopKit#16
The issue this addresses would not be noticed with Loop, as Loop rounds before attempting to enact a temporary basal rate. This issue became apparent when using Trio, though, since Trio does not round before attempting to enact a temporary basal rate, leaving the task of rounding up to the pump's submodule. OmniBLE and OmniKit both already internally handle this rounding task, so this PR aims to add it to MinimedKit as well.
I added this commit to my in-vitro build of Trio-dev.
I added a debugging log message in Trio whenever it attempts to enact a temp basal rate that is unsupported by the pump. Before when this was triggered, I would check Trio's History and see two temp basal records for the same time and one of them would be for the unsupported rate. Here's an example of that:
Since adding this commit to my in-vitro Trio build, however, I have had a couple log messages for attempts to enact an unsupported basal rate, but Trio's History only shows the single rounded and supported temp basal rate. Given this, I think this commit solves this issue.