Message transport refactoring and various update merge#1
Merged
Conversation
Collaborator
itsmojo
commented
Mar 15, 2025
- Define protocols for MessageTransportState, MessageTransportDelegate & MessageTransport
- Use separate transport implementations for Eros and Ble
- Use a single PodMessageTransport log name for both Eros and Ble
- Make more funcs and variables private
- Improved PodComms names & commenting denoting Eros and Ble specific items
- Group Eros and Ble specific entries together in PodState
- Now use new updated DeliveryUncertaintyRecoveryView on comms errors
- Provides different recovery suggestions depending on whether a RL is used
- Improved debugDescription for BleMessageTransportState, PodState & PodComms
- Many README updates
Contributor
marionbarker
left a comment
There was a problem hiding this comment.
Code Review
Looks good but will do some testing as well.
Some comments sent via private message with suggested string changes.
marionbarker
approved these changes
Mar 18, 2025
Contributor
marionbarker
left a comment
There was a problem hiding this comment.
Sent via PM:
- a correction for
OmniTests/PodCommsSessionTests.swift - pointed out a duplicate word in README.md ("the the").
Those do not affect the function of the code.
- Tested DASH pod using rPi DASH simulator
- Tested Eros pod using an actual pod
Exercised all the functions of the OmnipodKit manager for Eros and DASH including the new method for handling uncertain comms.
Contributor
|
Reviewed final commit. Tested the build again. works with BLE rPi and Eros pod. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.