Skip to content

Update workspace patches and README for adding OmnipodKit#2

Merged
marionbarker merged 5 commits into
mainfrom
update_workspace_patches
Mar 20, 2025
Merged

Update workspace patches and README for adding OmnipodKit#2
marionbarker merged 5 commits into
mainfrom
update_workspace_patches

Conversation

@marionbarker
Copy link
Copy Markdown
Contributor

@marionbarker marionbarker commented Mar 19, 2025

Purpose

Simplify addition of OmnipodKit to Loop or Trio

Details

  • Rename folder from patch to patches
  • Add a patch to add OmnipodKit to LoopWorkspace
  • Update the patch to add OmnipodKit to Trio
  • Update the README file with new instructions and clarify some language

Tests

LoopWorkspace

When testing this from a new clone for LoopWorkspace, use these instructions instead of what is currently in the README so you can test the appropriate branch. Do not forget to close the LoopWorkspace folder in Xcode and paste these commands in the LoopWorkspace folder in Terminal.

git clone --branch=update_workspace_patches https://github.com/loopandlearn/OmnipodKit.git
git apply OmnipodKit/patches/add_omnipodkit_to_LoopWorkspace.patch
xed .

Trio-dev

When testing this from a new clone for Trio-dev, use these instructions instead of what is currently in the README so you can test the appropriate branch. Do not forget to close the Trio folder in Xcode and paste these commands in the Trio folder in Terminal.

git clone --branch=update_workspace_patches https://github.com/loopandlearn/OmnipodKit.git
git apply OmnipodKit/patches/add_omnipodkit_to_Trio-dev.patch
xed .

At one point, the TrioTests were not working: if those tests fail, then right click on TrioTests to exclude them; or just run the OmniTests separately.

@marionbarker marionbarker requested a review from itsmojo March 19, 2025 16:20
@itsmojo
Copy link
Copy Markdown
Collaborator

itsmojo commented Mar 20, 2025

Verified installation and the results both LoopWorkspace (both dev and main). README updates and improvements good. Only suggestions at this time are to update the README to change "with the rPi DASH simulator" to "with a DASH pod or the rPi DASH simulator" and perhaps add something in the "To Add to LoopWorkspace" section noting that these instructions work for the both the current main and dev LoopWorkspace branches.

Copy link
Copy Markdown
Collaborator

@itsmojo itsmojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the LoopWorkspace installation patch Marion. See above comments regarding suggested README tweaks.

@marionbarker
Copy link
Copy Markdown
Contributor Author

I am not adding the comment about this working with main and dev for LoopWorkspace because the current status may change soon. As it is today, the dev branch is actually behind the main branch in terms of submodules included.

I modified the Status section with your suggestions.

@marionbarker marionbarker merged commit a0ad672 into main Mar 20, 2025
@marionbarker marionbarker deleted the update_workspace_patches branch March 20, 2025 15:34
marionbarker added a commit that referenced this pull request Mar 6, 2026
@marionbarker marionbarker mentioned this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants