Update workspace patches and README for adding OmnipodKit#2
Conversation
|
Verified installation and the results both LoopWorkspace (both dev and main). README updates and improvements good. Only suggestions at this time are to update the README to change "with the rPi DASH simulator" to "with a DASH pod or the rPi DASH simulator" and perhaps add something in the "To Add to LoopWorkspace" section noting that these instructions work for the both the current main and dev LoopWorkspace branches. |
itsmojo
left a comment
There was a problem hiding this comment.
Thanks for creating the LoopWorkspace installation patch Marion. See above comments regarding suggested README tweaks.
|
I am not adding the comment about this working with I modified the Status section with your suggestions. |
Purpose
Simplify addition of OmnipodKit to Loop or Trio
Details
patchtopatchesTests
LoopWorkspace
When testing this from a new clone for LoopWorkspace, use these instructions instead of what is currently in the README so you can test the appropriate branch. Do not forget to close the LoopWorkspace folder in Xcode and paste these commands in the LoopWorkspace folder in Terminal.
Trio-dev
When testing this from a new clone for Trio-dev, use these instructions instead of what is currently in the README so you can test the appropriate branch. Do not forget to close the Trio folder in Xcode and paste these commands in the Trio folder in Terminal.
At one point, the TrioTests were not working: if those tests fail, then right click on TrioTests to exclude them; or just run the OmniTests separately.