Conversation
bajtos
reviewed
Aug 28, 2018
bajtos
left a comment
bajtos
left a comment
Member
There was a problem hiding this comment.
Please note this is a breaking change that should be released in a semver-major release.
| "quotes": ["error", "single", "avoid-escape"], | ||
| "semi-spacing": ["error", {"before": false, "after": true}], | ||
| "semi": ["error", "always"], | ||
| "no-extra-semi": "error", |
Member
There was a problem hiding this comment.
I believe we are keeping the options sorted by alphabet, i.e. no-extra-semi should be inside the group of other no-* options.
Contributor
Author
@bajtos I see. Yeah we should upgrade all LB3 modules by applying this new rule after releasing a major version. |
virkt25
approved these changes
Aug 28, 2018
Contributor
|
All of the downstream CI failures here indicate failures that will happen when this PR is merged. To properly reflect the semver-major nature of the change, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A follow up PR based on comment strongloop/generator-loopback#363 (comment)