Conversation
| @@ -33,7 +33,7 @@ db.autoupdate('User', function(err) { | |||
| }); | |||
There was a problem hiding this comment.
Need this line at the beginning of file
var g = require('strong-globalize')();
superkhau
force-pushed
the
globalization
branch
3 times, most recently
from
1975ff9 to
b6d3bab
Compare
|
@0candy PTAL again |
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "5bdcd0e36db5b1100819f9aa25e9bdf0": "Cloudant {{regex}} syntax does not support global" | |||
| } | |||
There was a problem hiding this comment.
weird, how come still doesn't show the above string example complete?
There was a problem hiding this comment.
that is strange, checking now, i'll try rerunning linter
There was a problem hiding this comment.
its good now, reruning global slt-globalize -e did it now. probably because of the bug this morning during the demo with ./node_modules...
superkhau
force-pushed
the
globalization
branch
from
b6d3bab to
80684e2
Compare
| "lodash": "^3.10.1", | ||
| "loopback-connector": "^2.3.0" | ||
| "loopback-connector": "^2.3.0", | ||
| "strong-globalize": "^2.6.5" |
There was a problem hiding this comment.
Should we put ^2.6.6 as 2.6.5 has a bug? Probably not needed, up to you
There was a problem hiding this comment.
Caret will pick up 2.6.6 anyways, but I'll update it now while we have the chance.
|
LGTM |
|
Merging. Unrelated linting failures on CI. |
superkhau
force-pushed
the
globalization
branch
from
80684e2 to
1e78956
Compare
3 participants
@0candy PTAL