Remove TEST prefix for env vars - #292
Merged
Merged
Conversation
Contributor
Author
|
@rmg PTAL |
* TEST_ prefix is not used by CI anymore and there for serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MONGODB_HOST for example) convention
superkhau
force-pushed
the
remove-unused-env-vars
branch
from
October 7, 2016 00:22
892938b to
698b56c
Compare
rmg
approved these changes
Oct 7, 2016
rmg
left a comment
rmg
left a comment
Contributor
There was a problem hiding this comment.
This module's tests are all passing on CI and the changes can't affect downstream, so LGTM.
superkhau
added a commit
that referenced
this pull request
Oct 7, 2016
* TEST_ prefix is not used by CI anymore and there for serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MONGODB_HOST for example) convention Backport of #292
superkhau
added a commit
that referenced
this pull request
Oct 7, 2016
* TEST_ prefix is not used by CI anymore and there for serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MONGODB_HOST for example) convention
superkhau
added a commit
that referenced
this pull request
Oct 7, 2016
* TEST_ prefix is not used by CI anymore and there for serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MONGODB_HOST for example) convention Backport of #292
superkhau
added a commit
that referenced
this pull request
Oct 7, 2016
* TEST_ prefix is not used by CI anymore and therefore serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MONGODB_HOST for example) convention Backport of #292
superkhau
added a commit
that referenced
this pull request
Oct 7, 2016
bajtos
added a commit
that referenced
this pull request
Oct 17, 2016
* Remove TEST prefix for env vars (#292) (Simon Ho) * Add connectorCapabilities global object (Nick Duffy) * Update translation files - round#2 (Candy) * Update deps to loopback 3.0.0 RC (Miroslav Bajtoš) * Remove conflict (jannyHou) * fix maxDistance not supported in geo filter. (Vincent Wen) * Use juggler@3 for running the tests (Miroslav Bajtoš) * Remove !intl (jannyHou) * Refactor (jannyHou) * Globalization (jannyHou) * Support patches afterwards (jannyHou) * Use the latest compatible mongodb (jannyHou) * Update URLs in CONTRIBUTING.md (#264) (Ryan Graham)
fabien
pushed a commit
to fabien/loopback-connector-mongodb
that referenced
this pull request
Oct 22, 2016
* TEST_ prefix is not used by CI anymore and there for serve no purpose * Part of overall goal to standardize env var injection to MODULE_VARNAME (ie. MONGODB_HOST for example) convention
fabien
pushed a commit
to fabien/loopback-connector-mongodb
that referenced
this pull request
Oct 22, 2016
* Remove TEST prefix for env vars (loopbackio#292) (Simon Ho) * Add connectorCapabilities global object (Nick Duffy) * Update translation files - round#2 (Candy) * Update deps to loopback 3.0.0 RC (Miroslav Bajtoš) * Remove conflict (jannyHou) * fix maxDistance not supported in geo filter. (Vincent Wen) * Use juggler@3 for running the tests (Miroslav Bajtoš) * Remove !intl (jannyHou) * Refactor (jannyHou) * Globalization (jannyHou) * Support patches afterwards (jannyHou) * Use the latest compatible mongodb (jannyHou) * Update URLs in CONTRIBUTING.md (loopbackio#264) (Ryan Graham)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODULE_VARNAME (ie. MONGODB_HOST for example) convention
cc @bajtos @strongloop/fa-db-connectors