Skip to content

chore: improve issue and PR templates#404

Merged
nabdelgadir merged 1 commit into
masterfrom
chore/improve-issue-templates
Nov 15, 2019
Merged

chore: improve issue and PR templates#404
nabdelgadir merged 1 commit into
masterfrom
chore/improve-issue-templates

Conversation

@nabdelgadir

@nabdelgadir nabdelgadir commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Description

Improve issue and pull request templates to match loopback-next.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir nabdelgadir self-assigned this Nov 13, 2019
@nabdelgadir

nabdelgadir commented Nov 13, 2019

Copy link
Copy Markdown
Contributor Author

@slnode test please

@agnes512

agnes512 commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Do we need .github/ISSUE_TEMPLATE/Security_vulnerability.md as what we did in loopback-connector? Or we only need it in that package?

dhmlau
dhmlau reviewed Nov 13, 2019
View reviewed changes

@dhmlau dhmlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the security vulnerability template too? https://github.com/strongloop/loopback/pull/4266/files#diff-f66a7d4cdb1e7589643b3ee760ce09b6

jannyHou
jannyHou reviewed Nov 13, 2019
View reviewed changes

@jannyHou jannyHou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for disabling the vulnerability issue reporting. https://github.com/strongloop/loopback/pull/4266/files#diff-f66a7d4cdb1e7589643b3ee760ce09b6

Otherwise LGTM 👍

@nabdelgadir

nabdelgadir commented Nov 14, 2019

Copy link
Copy Markdown
Contributor Author

@agnes512 @dhmlau I made it consistent with loopbackio/loopback-next#4030, so that they're redirected towards email instead. I think we should keep it disabled like @jannyHou (and change loopback and loopback-connector to be consistent), but do you think we should allow security vulnerability issue reporting?

dhmlau
dhmlau approved these changes Nov 14, 2019
View reviewed changes

@dhmlau dhmlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabdelgadir
nabdelgadir merged commit ddb1c96 into master Nov 15, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the chore/improve-issue-templates branch November 15, 2019 16:49
@bajtos bajtos mentioned this pull request Nov 15, 2019
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau dhmlau approved these changes
@b-admike b-admike Awaiting requested review from b-admike
+3 more reviewers
@jannyHou jannyHou jannyHou left review comments
@emonddr emonddr emonddr approved these changes
@agnes512 agnes512 agnes512 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nabdelgadir nabdelgadir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nabdelgadir @agnes512 @emonddr @jannyHou @dhmlau